Re: [PATCH v3 0/6] Makefile: add {program,xdiff,test,git,fuzz}-objs & objects targets

From: Jeff King <peff@peff.net>
Date: Feb 23, 2021, 18:31 UTC
Message-ID: <YDVJ9wumbORxTmJ5@coredump.intra.peff.net>
In-Reply-To: <20210223114132.24345-1-avarab@gmail.com>

On Tue, Feb 23, 2021 at 12:41:26PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 9 quoted lines

> As Jeff points out in
> https://lore.kernel.org/git/YBuc5iOCCHk4fPqs@coredump.intra.peff.net/
> the use-case for having "{program-xdiff,test,git}-objs & objects"
> targets is a bit harder to justify.
> 
> I still think they're useful, particularly for testing on e.g. slow
> single-core VMs or other test setups (I use the GCC farm) where I know
> I just want to compile e.g. "test" objects, and compiling one of them
> takes 1-2 seconds.

OK. I doubt I'll end up using them myself, but I'll keep my eyes open for opportunities. But I agree they are not creating any kind of maintenance burden, since people would be touching the FOO_OBJS lists both before and after your patches anyway. So it does not hurt to try.

Show 7 quoted lines

> Ævar Arnfjörð Bjarmason (6):
>   Makefile: guard against TEST_OBJS in the environment
>   Makefile: split up long OBJECTS line
>   Makefile: sort OBJECTS assignment for subsequent change
>   Makefile: split OBJECTS into OBJECTS and GIT_OBJS
>   Makefile: add {program,xdiff,test,git,fuzz}-objs & objects targets
>   Makefile: build "$(FUZZ_OBJS)" in CI, not under "all"

The first five all look good to me. I'm skeptical of the final one; I wrote more comments in response to that patch.

-Peff