[PATCH v2 1/6] Makefile: remove "all" on "$(FUZZ_OBJS)"
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Feb 1, 2021, 11:17 UTC
- Message-ID
- <20210201111715.10200-2-avarab@gmail.com>
- In-Reply-To
- <20210128182310.26787-1-avarab@gmail.com>
Adding this as a dependency was intentionally done in 5e472150800 (fuzz: add basic fuzz testing target., 2018-10-12).
I don't see why we need to prevent bitrot here under "all" for these in particular, but not e.g. contrib/credential/**/*.c
In any case, these files are rather trivial and from their commit log it seems the fuzz-all target is run by a few people already.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- Makefile | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/Makefile b/Makefile index 4edfda3e009..65e600713c1 100644 --- a/Makefile +++ b/Makefile @@ -667,9 +667,6 @@ FUZZ_OBJS += fuzz-commit-graph.o FUZZ_OBJS += fuzz-pack-headers.o FUZZ_OBJS += fuzz-pack-idx.o -# Always build fuzz objects even if not testing, to prevent bit-rot. -all:: $(FUZZ_OBJS) - FUZZ_PROGRAMS += $(patsubst %.o,%,$(FUZZ_OBJS)) # Empty... @@ -3321,4 +3318,4 @@ $(FUZZ_PROGRAMS): all $(QUIET_LINK)$(CXX) $(FUZZ_CXXFLAGS) $(LIB_OBJS) $(BUILTIN_OBJS) \ $(XDIFF_OBJS) $(EXTLIBS) git.o $@.o $(LIB_FUZZING_ENGINE) -o $@ -fuzz-all: $(FUZZ_PROGRAMS) +fuzz-all: $(FUZZ_PROGRAMS) $(FUZZ_OBJS)
-- 2.30.0.284.gd98b1dd5eaa7