Re: [PATCH 00/11] FSMonitor Preliminary Commits

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 3, 2021, 21:19 UTC
Message-ID: <YBsTcDokmFcL8N1o@nand.local>
In-Reply-To: <pull.860.git.1612216941.gitgitgadget@gmail.com>

Hi Jeff,

On Mon, Feb 01, 2021 at 10:02:09PM +0000, Jeff Hostetler via GitGitGadget wrote:

Show 5 quoted lines

> This patch series fixes runtime errors in t/perf/p7519 on Windows and MacOS.
> It adds Trace2 logging to p7519 to make it easier to compare results when
> Watchman is enabled and disabled. And finally, it adds some Trace2 regions
> and data events around our usage of Watchman and the existing FSMonitor
> framework.

I read v2 of this series and it all looked very sane to me. I didn't have much in the way of comments or concerns along the way, so that version of the series has my reviewed-by.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.