git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 02/11] p7519: fix watchman watch-list test on Windows

From
JGJeff Hostetler via GitGitGadget <gitgitgadget@gmail.com>
Date
Feb 3, 2021, 15:34 UTC
Message-ID
<3042fc92fe6d5ff05fd2e4ac96ef936a69b2a2ff.1612366490.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.860.v2.git.1612366490.gitgitgadget@gmail.com>
From: Jeff Hostetler <jeffhost@microsoft.com>

Only use the final portion of the test trash directory file name when verifying that Watchman was started.

On Windows and under the SDK, $GIT_WORKTREE is a cygwin-style path with forward slashes and a "/c/" drive name. However `watchman watch-list` reports a proper Windows-style pathname with drive letters and backslashes. This causes the grep to fail. Since we don't really care about the full pathname (and we really don't want to bother with normalizaing them), just see if the test-name portion of the path is found.

Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
---
 t/perf/p7519-fsmonitor.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/perf/p7519-fsmonitor.sh b/t/perf/p7519-fsmonitor.sh
index 6677e0ef7ab..21d525541d5 100755
--- a/t/perf/p7519-fsmonitor.sh
+++ b/t/perf/p7519-fsmonitor.sh
@@ -101,7 +101,7 @@ test_expect_success "one time repo setup" '
 	# If Watchman exists, watch the work tree and attempt a query.
 	if test_have_prereq WATCHMAN; then
 		watchman watch "$GIT_WORK_TREE" &&
-		watchman watch-list | grep -q -F "$GIT_WORK_TREE"
+		watchman watch-list | grep -q -F "p7519-fsmonitor"
 	fi
 '
 
-- 
gitgitgadget
Previous: Jeff Hostetler via GitGitGadgetNext: Jeff Hostetler via GitGitGadget
Message 20 of 30 in “FSMonitor Preliminary Commits”
  1. 00/11 FSMonitor Preliminary CommitsJeff Hostetler via GitGitGadget, Feb 1, 2021
  2. 01/11 p7519: use xargs -0 rather than -d in testJeff Hostetler via GitGitGadget, Feb 1, 2021
  3. Junio C HamanoFeb 1, 2021
  4. Jeff HostetlerFeb 2, 2021
  5. Junio C HamanoFeb 2, 2021
  6. 02/11 p7519: fix watchman watch-list test on WindowsJeff Hostetler via GitGitGadget, Feb 1, 2021
  7. 09/11 fsmonitor: log FSMN token when reading and writing the indexJeff Hostetler via GitGitGadget, Feb 1, 2021
  8. 11/11 fsmonitor: refactor initialization of fsmonitor_last_update tokenJeff Hostetler via GitGitGadget, Feb 1, 2021
  9. 03/11 p7519: move watchman cleanup earlier in the testJeff Hostetler via GitGitGadget, Feb 1, 2021
  10. 04/11 p7519: add trace logging during perf testJeff Hostetler via GitGitGadget, Feb 1, 2021
  11. 05/11 preload-index: log the number of lstat calls to trace2Jeff Hostetler via GitGitGadget, Feb 1, 2021
  12. 07/11 read-cache: log the number of scanned files to trace2Jeff Hostetler via GitGitGadget, Feb 1, 2021
  13. 10/11 fsmonitor: allow all entries for a folder to be invalidatedKevin Willford via GitGitGadget, Feb 1, 2021
  14. 08/11 fsmonitor: log invocation of FSMonitor hook to trace2Jeff Hostetler via GitGitGadget, Feb 1, 2021
  15. 06/11 read-cache: log the number of lstat calls to trace2Jeff Hostetler via GitGitGadget, Feb 1, 2021
  16. 00/11 FSMonitor Preliminary CommitsJeff Hostetler via GitGitGadget, Feb 3, 2021
  17. 03/11 p7519: move watchman cleanup earlier in the testJeff Hostetler via GitGitGadget, Feb 3, 2021
  18. 04/11 p7519: add trace logging during perf testJeff Hostetler via GitGitGadget, Feb 3, 2021
  19. 01/11 p7519: do not rely on "xargs -d" in testJeff Hostetler via GitGitGadget, Feb 3, 2021
  20. 02/11 p7519: fix watchman watch-list test on WindowsJeff Hostetler via GitGitGadget, Feb 3, 2021
  21. 06/11 read-cache: log the number of lstat calls to trace2Jeff Hostetler via GitGitGadget, Feb 3, 2021
  22. 07/11 read-cache: log the number of scanned files to trace2Jeff Hostetler via GitGitGadget, Feb 3, 2021
  23. 11/11 fsmonitor: refactor initialization of fsmonitor_last_update tokenJeff Hostetler via GitGitGadget, Feb 3, 2021
  24. 09/11 fsmonitor: log FSMN token when reading and writing the indexJeff Hostetler via GitGitGadget, Feb 3, 2021
  25. 10/11 fsmonitor: allow all entries for a folder to be invalidatedKevin Willford via GitGitGadget, Feb 3, 2021
  26. 08/11 fsmonitor: log invocation of FSMonitor hook to trace2Jeff Hostetler via GitGitGadget, Feb 3, 2021
  27. 05/11 preload-index: log the number of lstat calls to trace2Jeff Hostetler via GitGitGadget, Feb 3, 2021
  28. Jeff HostetlerFeb 16, 2021
  29. Junio C HamanoFeb 17, 2021
  30. Taylor BlauFeb 3, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.