From: Taylor Blau <me@ttaylorr.com>
Date: Wed, 03 Feb 2021 21:19:44 GMT
Subject: Re: [PATCH 00/11] FSMonitor Preliminary Commits
Message-ID: <YBsTcDokmFcL8N1o@nand.local>
In-Reply-To: <pull.860.git.1612216941.gitgitgadget@gmail.com>

Hi Jeff,

On Mon, Feb 01, 2021 at 10:02:09PM +0000, Jeff Hostetler via GitGitGadget wrote:
> This patch series fixes runtime errors in t/perf/p7519 on Windows and MacOS.
> It adds Trace2 logging to p7519 to make it easier to compare results when
> Watchman is enabled and disabled. And finally, it adds some Trace2 regions
> and data events around our usage of Watchman and the existing FSMonitor
> framework.

I read v2 of this series and it all looked very sane to me. I didn't
have much in the way of comments or concerns along the way, so that
version of the series has my reviewed-by.

Thanks,
Taylor