git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] annotate-tests: quote variable expansions containing path names

From
Jeff King <peff@peff.net>
Date
Feb 3, 2021, 05:22 UTC
Message-ID
<YBoy/F3tS3JtyhDX@coredump.intra.peff.net>
In-Reply-To
<762b6a24-15ef-7578-6064-eb82832699a4@gmail.com>
On Sat, Jan 30, 2021 at 12:14:56PM -0500, Philippe Blain wrote:
> Apart from that, maybe we could set up one of the CI jobs to
> clone git.git into a path with spaces, to try to avoid these
> kind of errors in the future ?

We put a space in the temporary trash directory created by the test suite for exactly this purpose. So I was curious why it didn't detect this problem.

It looks like it's because the issue is with $TEST_DIRECTORY, which is outside the trash directory.

-Peff
Previous: Philippe BlainNext: Johannes Sixt
Message 3 of 4 in “annotate-tests: quote variable expansions containing path names”
  1. annotate-tests: quote variable expansions containing path namesJohannes Sixt, Jan 30, 2021
  2. Philippe BlainJan 30, 2021
  3. Jeff KingFeb 3, 2021
  4. Johannes SixtFeb 3, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.