From: Jeff King Date: Wed, 03 Feb 2021 05:22:04 GMT Subject: Re: [PATCH] annotate-tests: quote variable expansions containing path names Message-ID: In-Reply-To: <762b6a24-15ef-7578-6064-eb82832699a4@gmail.com> On Sat, Jan 30, 2021 at 12:14:56PM -0500, Philippe Blain wrote: > Apart from that, maybe we could set up one of the CI jobs to > clone git.git into a path with spaces, to try to avoid these > kind of errors in the future ? We put a space in the temporary trash directory created by the test suite for exactly this purpose. So I was curious why it didn't detect this problem. It looks like it's because the issue is with $TEST_DIRECTORY, which is outside the trash directory. -Peff