Re: [PATCH] annotate-tests: quote variable expansions containing path names

From: Johannes Sixt <j6t@kdbg.org>
Date: Feb 3, 2021, 17:23 UTC
Message-ID: <f667e887-0ba0-af0a-91a9-d84d833422b0@kdbg.org>
In-Reply-To: <YBoy/F3tS3JtyhDX@coredump.intra.peff.net>

Am 03.02.21 um 06:22 schrieb Jeff King:

Show 12 quoted lines

> On Sat, Jan 30, 2021 at 12:14:56PM -0500, Philippe Blain wrote:
> 
>> Apart from that, maybe we could set up one of the CI jobs to
>> clone git.git into a path with spaces, to try to avoid these
>> kind of errors in the future ?
> 
> We put a space in the temporary trash directory created by the test
> suite for exactly this purpose. So I was curious why it didn't detect
> this problem.
> 
> It looks like it's because the issue is with $TEST_DIRECTORY, which is
> outside the trash directory.

Yes, correct. I was also suprised at first that this was not caught.

-- Hannes