Re: [PATCH v3 03/10] builtin/index-pack.c: allow stripping arbitrary extensions

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 29, 2021, 01:15 UTC
Message-ID: <YBNhqDTG5dEcIbWP@nand.local>
In-Reply-To: <YBNWsJBDUpNiRXP4@coredump.intra.peff.net>

On Thu, Jan 28, 2021 at 07:28:32PM -0500, Jeff King wrote:

Show 7 quoted lines

> On Mon, Jan 25, 2021 at 06:37:22PM -0500, Taylor Blau wrote:
> > Prepare for stripping off suffixes other than '.pack' by making the
> > suffix to strip a parameter of derive_filename(). In order to make this
> > consistent with the "suffix" parameter which does not begin with a ".",
> > an additional check in derive_filename.
>
> Maybe "add" missing from the final line?

Oops, yeah. I'm happy to send a replacement to help with queuing, if the maintainer thinks that would be helpful.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.