Re: [PATCH v3 08/10] t: support GIT_TEST_WRITE_REV_INDEX

From: Jeff King <peff@peff.net>
Date: Jan 29, 2021, 00:47 UTC
Message-ID: <YBNbM1STgzXxfe0u@coredump.intra.peff.net>
In-Reply-To: <02550a251de4f477a537968fda921b52586794dc.1611617820.git.me@ttaylorr.com>

On Mon, Jan 25, 2021 at 06:37:42PM -0500, Taylor Blau wrote:

Show 8 quoted lines

> Add a new option that unconditionally enables the pack.writeReverseIndex
> setting in order to run the whole test suite in a mode that generates
> on-disk reverse indexes. Additionally, enable this mode in the second
> run of tests under linux-gcc in 'ci/run-build-and-tests.sh'.
> 
> Once on-disk reverse indexes are proven out over several releases, we
> can change the default value of that configuration to 'true', and drop
> this patch.

Sounds like a good plan.

Show 11 quoted lines

> diff --git a/pack-revindex.h b/pack-revindex.h
> index 61b2f3ab75..d1a0595e89 100644
> --- a/pack-revindex.h
> +++ b/pack-revindex.h
> @@ -16,9 +16,12 @@
>   *   can be found
>   */
>  
> +
>  #define RIDX_SIGNATURE 0x52494458 /* "RIDX" */
>  #define RIDX_VERSION 1

Funny stray whitespace.

-Peff