Re: [PATCH v2 1/3] ci (check-whitespace): suggest fixes for errors

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: Dec 21, 2022, 13:46 UTC
Message-ID: <Y6MOLVoo/NtJy1C9@danh.dev>
In-Reply-To: <CAGT1KpWBVcmxCJf=j7ks7azrX=oj3zLqbrThOjjPLqKu+8rBAg@mail.gmail.com>

On 2022-12-20 22:08:58-0800, Chris Webster <chris@webstech.net> wrote:

Show 9 quoted lines

> On Tue, Dec 20, 2022 at 5:53 PM Đoàn Trần Công Danh
> <congdanhqx@gmail.com> wrote:
> > Yes, I think, a patch to move the whole block into a script, maybe in
> > ci/ folder.
> 
> Maybe before the next patch or someone could create a check-whitespace
> workflow action.  Can this patch move forward?  A script would involve
> validating parameters or env variables that are just workflow context
> expressions now (ie more complexity).

I would say, we can just check an environment variables specific to GitHub Action, and print a warning if it's missing. Other than that, just process as normal.

Show 9 quoted lines

> > > I am not sure what you mean.
> >
> > I mean we can write:
> >
> >         echo 'Run `git rebase ...` to correct the problem'
> >
> > With single quote, we need less escape.
> 
> What about ${lastcommit}?  Yes, there is more than one way to do it.

Ah, I misread that part. Sorry.

-- 
Danh