Re: [PATCH v2 1/3] ci (check-whitespace): suggest fixes for errors

From: Chris Webster <chris@webstech.net>
Date: Dec 21, 2022, 06:08 UTC
Message-ID: <CAGT1KpWBVcmxCJf=j7ks7azrX=oj3zLqbrThOjjPLqKu+8rBAg@mail.gmail.com>
In-Reply-To: <Y6JnEQY2VWU8gSZX@danh.dev>

On Tue, Dec 20, 2022 at 5:53 PM Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:

> Yes, I think, a patch to move the whole block into a script, maybe in
> ci/ folder.

Maybe before the next patch or someone could create a check-whitespace workflow action. Can this patch move forward? A script would involve validating parameters or env variables that are just workflow context expressions now (ie more complexity).

Show 7 quoted lines

> > I am not sure what you mean.
>
> I mean we can write:
>
>         echo 'Run `git rebase ...` to correct the problem'
>
> With single quote, we need less escape.

What about ${lastcommit}?  Yes, there is more than one way to do it.

thanks, ...chris.