Re: [PATCH v2 1/3] ci (check-whitespace): suggest fixes for errors

From

Chris Webster <chris@webstech.net>

Date

Dec 20, 2022, 19:55 UTC

Message-ID

<CAGT1KpV0igMKk4FvapuZCdJ7kFS+_cNe2ouczQsomheOGhgLZg@mail.gmail.com>

In-Reply-To

<Y6Fle8gzVU5si3T/@danh.dev>

> I think this change is getting too long to be embeded in a yaml file.
> I think it's better to move the shell code into its own script, so we
> can have better code highlight in editor and a proper shebang (/bin/bash).

That would need to be a separate patch?

> > +          echo "Run \`git rebase --whitespace=fix ${lastcommit}\` and \`git push --force\` to correct the problem." >>$GITHUB_STEP_SUMMARY
>
> When move this block into its own script, we can use single quote
> string here, too.

I am not sure what you mean.