Re: Skipping adding Signed-off-by even if it's not the last on git commit

From: Jeff King <peff@peff.net>
Date: Dec 9, 2022, 20:39 UTC
Message-ID: <Y5OdHL4VFCIjgrk7@coredump.intra.peff.net>
In-Reply-To: <xmqqcz8t1avz.fsf@gitster.g>

On Fri, Dec 09, 2022 at 01:03:44PM +0900, Junio C Hamano wrote:

Show 10 quoted lines

> > What I don't like about it is:
> >
> >   - the external cmd is complicated and slow. It would be nice if you
> >     could just set trailer.sign.ident=true or something, and it would
> >     use your ident by default if no value is given (and maybe even do
> >     completion similar to "commit --author" if a value is given).
> 
> Ah, "trailer.sign.value" to use the same value does not exist, and
> the closest kludge we can use is the .cmd thing?  Then it is a shame
> but it should be easy to correct?

Yeah, I almost suggested trailer.sign.value at first, but on further thought, it would be kind of weird. When the user asks for a trailer to be included, it usually already has a value along with it. This could be thought of as a default value, which might work like:

  git config trailer.signed-off-by.default "Jeff King <peff@peff.net>"

That's pretty flexible, but it seems like what you really want is not some string, but to say "my usual committer ident". And so we force you to repeat what's in user.email, etc, or we have to invent some new token that means "my usual ident". So if we instead have a flag for "this is an ident", then it can just do the expected thing.

Show 8 quoted lines

> >   - you have to know to be clever enough to define and use
> >     --trailer=sign. If --signoff didn't exist, that's not too big a
> >     stretch. But since it does, everyone will naturally reach for it
> >     first.
> 
> We could reimplement --signoff to actually take attention to the
> "trailer.sign.*" thing, if we wanted to, and that makes it very easy
> to explain, I guess.

Yeah. My only reservation would be whether anybody would be surprised by the change in behavior. I have the feeling that hardly anybody uses trailer.* config, but I admit that's not based in any real data.

-Peff