Re: Skipping adding Signed-off-by even if it's not the last on git commit

From: Taylor Blau <me@ttaylorr.com>
Date: Dec 7, 2022, 22:13 UTC
Message-ID: <Y5EQCD4XCsN10HO+@nand.local>
In-Reply-To: <20221207084027.7dhyaatkzaawrg4g@vulcanus>

On Wed, Dec 07, 2022 at 09:40:27AM +0100, David Caro wrote:

Show 18 quoted lines

> On 12/07 13:11, Junio C Hamano wrote:
> > Taylor Blau <me@ttaylorr.com> writes:
> >
> > >> I propose enabling it for commit, merge and am.
> > >
> > > So I think that there are some legitimate uses outside of 'format-patch'
> > > that we may want to keep the existing behavior. So I don't think we
> > > should necessarily change the default to have other commands outside of
> > > 'format-patch' start passing APPEND_SIGNOFF_DEDUP.
> > >
> > > But I could see a future where we add a new option that controls whether
> > > or not we pass that flag, perhaps:
> > >
> > >     $ git commit --signoff[=[no-]dedup]
> >
> > That sounds sensible.
>
> Agree, I will implement this then for commit for now, thanks!

Thanks, I look forward to seeing your work. It would be nice to standardize on this `--signoff[=[no-]dedup]` thing throughout all of the different commands that support it.

According to:

    $ git grep -- '--signoff' -- Documentation/git-*.txt

that list is: `git am`, `git cherry-pick`, `git format-patch`, `git rebase`, and `git revert`. But there are others, too, via an include of `signoff-option.txt`, so that is `git commit`, `git merge`, and `git pull`.

Phew ;-).

Thanks, Taylor