git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Skipping adding Signed-off-by even if it's not the last on git commit

From
David Caro <dcaro@wikimedia.org>
Date
Dec 6, 2022, 17:06 UTC
Message-ID
<20221206170646.6lnpr6h7oprziy5b@vulcanus>
Hi!

I have noticed that when requesting git commit to add the Signed-off-by header, it will add it even if it already exists as long as it's not the last in the footer.

It seems that the functionality to do so has been there for a while (see [1]) and it's being used effectively on format-patch, but it was never enabled for the rest of commands.

I propose enabling it for commit, merge and am.
I can easily send a patch for it if the change is welcome.
Thanks!
[1] https://github.com/git/git/commit/bab4d1097c8be7d688a53b992232063dbf300fd4
-- 
David Caro
SRE - Cloud Services
Wikimedia Foundation <https://wikimediafoundation.org/>
PGP Signature: 7180 83A2 AC8B 314F B4CE  1171 4071 C7E1 D262 69C3

"Imagine a world in which every single human being can freely share in the
sum of all knowledge. That's our commitment."
Next: Taylor Blau
Message 1 of 14 in “Skipping adding Signed-off-by even if it's not the last on git commit”
  1. David CaroDec 6, 2022
  2. Taylor BlauDec 7, 2022
  3. Junio C HamanoDec 7, 2022
  4. David CaroDec 7, 2022
  5. Taylor BlauDec 7, 2022
  6. Junio C HamanoDec 7, 2022
  7. Jeff KingDec 8, 2022
  8. Junio C HamanoDec 9, 2022
  9. Jeff KingDec 9, 2022
  10. Junio C HamanoDec 9, 2022
  11. Jeff KingDec 9, 2022
  12. Ævar Arnfjörð BjarmasonDec 7, 2022
  13. Junio C HamanoDec 7, 2022
  14. Konstantin RyabitsevDec 7, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.