Re: [PATCH] test-lib.sh: discover "git" in subdirs of "contrib/buildsystems/out"
- From
Jeff King <peff@peff.net>
- Date
- Dec 6, 2022, 02:05 UTC
- Message-ID
- <Y46jT0i/7DhxHzfS@coredump.intra.peff.net>
- In-Reply-To
- <221206.86zgc1cnc3.gmgdl@evledraar.gmail.com>
On Tue, Dec 06, 2022 at 02:43:17AM +0100, Ævar Arnfjörð Bjarmason wrote:
Show 7 quoted lines
> > I don't mind having it in-tree if I can ignore it (assuming the project > > attitude is the "it's a side thing" from above). It's the CI failures > > that make it hard to ignore. > > ...but on this thread-at-large, I'd much rather see us focus on just > reviewing the patches I have here than raising the burden of proof to > whether we should get rid of it entirely.
Fair. In case it is not obvious, I have no interest in reviewing cmake patches. ;) But I will at least stop making noise in the thread.
> If we make the CI failures "soft" failures or move it out-of-tree > entirely it would still be useful to be able to run the cmake recipe on > *nix.
Agreed.
-Peff