Re: ds/bundle-uri-4 (was Re: What's cooking in git.git (Nov 2022, #07; Tue, 29))

From: Derrick Stolee <derrickstolee@github.com>
Date: Dec 1, 2022, 15:06 UTC
Message-ID: <81dbae6e-b198-c056-5107-99c88ce77f94@github.com>
In-Reply-To: <b223202b-0ae2-bdb5-e9d6-21a6321a9e31@github.com>

On 11/29/2022 4:16 PM, Derrick Stolee wrote:

Show 24 quoted lines

> On 11/29/2022 4:40 AM, Junio C Hamano wrote:
> 
>> * ds/bundle-uri-4 (2022-11-16) 9 commits
>>  - clone: unbundle the advertised bundles
>>  - bundle-uri: download bundles from an advertised list
>>  - bundle-uri: allow relative URLs in bundle lists
>>  - strbuf: introduce strbuf_strip_file_from_path()
>>  - bundle-uri client: add boolean transfer.bundleURI setting
>>  - bundle-uri: serve bundle.* keys from config
>>  - bundle-uri client: add helper for testing server
>>  - bundle-uri client: add minimal NOOP client
>>  - protocol v2: add server-side "bundle-uri" skeleton
>>
>>  Bundle URIs part 4.
>>
>>  Waiting for review.
>>  Seems to break CI.
>>  cf. https://github.com/git/git/actions/runs/3560918726
>>  source: <pull.1400.v2.git.1668628302.gitgitgadget@gmail.com>
> 
> Thanks for pointing this out. I'll be sure to fix the relevant
> failures in linux-TEST-vars [1] before the next version.
> 
> [1] https://github.com/git/git/actions/runs/3560918726/jobs/5981349269#step:4:1854

I have discovered that the problem is due to the test variable GIT_TEST_PACKED_REFS_VERSION=2, so instead it's probably best to eject ds/packed-refs-v2 from 'seen' instead of ds/bundle-uri-4.

Thanks, -Stolee