git/list[1] front-page[2] threads[3] people[4] search[5] about
 

ab/cmake-nix-and-ci (was Re: What's cooking in git.git (Nov 2022, #07; Tue, 29))

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Nov 30, 2022, 09:57 UTC
Message-ID
<544fff8a-7d56-57a1-00a3-d1a9302e227c@dunelm.org.uk>
In-Reply-To
<xmqqsfi22j67.fsf@gitster.g>
Hi Junio
On 29/11/2022 09:40, Junio C Hamano wrote:
Show 18 quoted lines
> * ab/cmake-nix-and-ci (2022-11-04) 14 commits
>    (merged to 'next' on 2022-11-08 at 6ef4e93b36)
>   + CI: add a "linux-cmake-test" to run cmake & ctest on linux
>   + cmake: copy over git-p4.py for t983[56] perforce test
>   + cmake: only look for "sh" in "C:/Program Files" on Windows
>   + cmake: increase test timeout on Windows only
>   + cmake: support GIT_TEST_OPTS, abstract away WIN32 defaults
>   + Makefile + cmake: use environment, not GIT-BUILD-DIR
>   + test-lib.sh: support a "GIT_TEST_BUILD_DIR"
>   + cmake: set "USE_LIBPCRE2" in "GIT-BUILD-OPTIONS" for test-lib.sh
>   + cmake & test-lib.sh: add a $GIT_SOURCE_DIR variable
>   + cmake: chmod +x the bin-wrappers/* & SCRIPT_{SH,PERL} & git-p4
>   + cmake: don't copy chainlint.pl to build directory
>   + cmake: update instructions for portable CMakeLists.txt
>   + cmake: use "-S" and "-B" to specify source and build directories
>   + cmake: don't invoke msgfmt with --statistics
> 
>   Fix assorted issues with CTest on *nix machines.

If that's all this series did then I think it would be fine. However it also makes changes to test-lib.sh to hard code the build directory in an attempt to remove GIT-BUILD-DIR. I'm not convinced that is an improvement on the status quo. As I mentioned previously [1] I think the non-*nix related patches could do with a review from the windows folks before this hits master.

Best Wishes
Phillip

[1] https://lore.kernel.org/git/64b91b29-bbcd-e946-1f20-c0a5be63d9b7@dunelm.org.uk/

>   Will cook in 'next'.
>   source: <cover-v4-00.14-00000000000-20221103T160255Z-avarab@gmail.com>
Previous: Junio C HamanoNext: Ævar Arnfjörð Bjarmason
Message 15 of 43 in “What's cooking in git.git (Nov 2022, #07; Tue, 29)”
  1. Junio C HamanoNov 29, 2022
  2. ab/remove--super-prefix and -rc0 (was What's cooking in git.git (Nov 2022, #07; Tue, 29))Glen Choo, Nov 29, 2022
  3. Junio C HamanoNov 30, 2022
  4. Glen ChooNov 30, 2022
  5. Ævar Arnfjörð BjarmasonNov 30, 2022
  6. Junio C HamanoDec 1, 2022
  7. Glen ChooDec 1, 2022
  8. Junio C HamanoDec 1, 2022
  9. Glen ChooNov 29, 2022
  10. Junio C HamanoNov 30, 2022
  11. Glen ChooNov 30, 2022
  12. ds/bundle-uri-4 (was Re: What's cooking in git.git (Nov 2022, #07; Tue, 29))Derrick Stolee, Nov 29, 2022
  13. Derrick StoleeDec 1, 2022
  14. Junio C HamanoDec 2, 2022
  15. ab/cmake-nix-and-ci (was Re: What's cooking in git.git (Nov 2022, #07; Tue, 29))Phillip Wood, Nov 30, 2022
  16. Ævar Arnfjörð BjarmasonNov 30, 2022
  17. Phillip WoodDec 1, 2022
  18. test-lib.sh: discover "git" in subdirs of "contrib/buildsystems/out"Ævar Arnfjörð Bjarmason, Dec 1, 2022
  19. Phillip WoodDec 1, 2022
  20. Ævar Arnfjörð BjarmasonDec 1, 2022
  21. Junio C HamanoDec 1, 2022
  22. Phillip WoodDec 2, 2022
  23. Ævar Arnfjörð BjarmasonDec 2, 2022
  24. Jeff KingDec 2, 2022
  25. Junio C HamanoDec 3, 2022
  26. Ævar Arnfjörð BjarmasonDec 3, 2022
  27. Jeff KingDec 5, 2022
  28. Taylor BlauDec 5, 2022
  29. Ævar Arnfjörð BjarmasonDec 5, 2022
  30. Taylor BlauDec 6, 2022
  31. Jeff KingDec 6, 2022
  32. Ævar Arnfjörð BjarmasonDec 6, 2022
  33. Jeff KingDec 6, 2022
  34. Ævar Arnfjörð BjarmasonDec 6, 2022
  35. Junio C HamanoDec 6, 2022
  36. Phillip WoodDec 6, 2022
  37. Ævar Arnfjörð BjarmasonDec 6, 2022
  38. ab/cmake-nix-and-ci, was Re: [PATCH] test-lib.sh: discover "git" in subdirs of "contrib/buildsystems/out"Johannes Schindelin, Dec 8, 2022
  39. Ævar Arnfjörð BjarmasonDec 8, 2022
  40. Junio C HamanoDec 9, 2022
  41. Ævar Arnfjörð BjarmasonDec 9, 2022
  42. Taylor BlauDec 7, 2022
  43. Phillip WoodNov 30, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.