ab/cmake-nix-and-ci (was Re: What's cooking in git.git (Nov 2022, #07; Tue, 29))
- From
- Phillip Wood <phillip.wood123@gmail.com>
- Date
- Nov 30, 2022, 09:57 UTC
- Message-ID
- <544fff8a-7d56-57a1-00a3-d1a9302e227c@dunelm.org.uk>
- In-Reply-To
- <xmqqsfi22j67.fsf@gitster.g>
Hi Junio
On 29/11/2022 09:40, Junio C Hamano wrote:
Show 18 quoted lines
> * ab/cmake-nix-and-ci (2022-11-04) 14 commits
> (merged to 'next' on 2022-11-08 at 6ef4e93b36)
> + CI: add a "linux-cmake-test" to run cmake & ctest on linux
> + cmake: copy over git-p4.py for t983[56] perforce test
> + cmake: only look for "sh" in "C:/Program Files" on Windows
> + cmake: increase test timeout on Windows only
> + cmake: support GIT_TEST_OPTS, abstract away WIN32 defaults
> + Makefile + cmake: use environment, not GIT-BUILD-DIR
> + test-lib.sh: support a "GIT_TEST_BUILD_DIR"
> + cmake: set "USE_LIBPCRE2" in "GIT-BUILD-OPTIONS" for test-lib.sh
> + cmake & test-lib.sh: add a $GIT_SOURCE_DIR variable
> + cmake: chmod +x the bin-wrappers/* & SCRIPT_{SH,PERL} & git-p4
> + cmake: don't copy chainlint.pl to build directory
> + cmake: update instructions for portable CMakeLists.txt
> + cmake: use "-S" and "-B" to specify source and build directories
> + cmake: don't invoke msgfmt with --statistics
>
> Fix assorted issues with CTest on *nix machines.If that's all this series did then I think it would be fine. However it also makes changes to test-lib.sh to hard code the build directory in an attempt to remove GIT-BUILD-DIR. I'm not convinced that is an improvement on the status quo. As I mentioned previously [1] I think the non-*nix related patches could do with a review from the windows folks before this hits master.
Best Wishes
Phillip
[1] https://lore.kernel.org/git/64b91b29-bbcd-e946-1f20-c0a5be63d9b7@dunelm.org.uk/
> Will cook in 'next'. > source: <cover-v4-00.14-00000000000-20221103T160255Z-avarab@gmail.com>