Re: [PATCH v2 00/11] Turn git-bisect to be builtin

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 15, 2022, 19:40 UTC
Message-ID: <Y3PrIgynUYFtrqnB@nand.local>
In-Reply-To: <Y3PqLMzC8DBPjp10@coredump.intra.peff.net>

On Tue, Nov 15, 2022 at 02:36:12PM -0500, Jeff King wrote:

Show 18 quoted lines

> On Tue, Nov 15, 2022 at 02:18:24PM -0500, Taylor Blau wrote:
>
> > Hmm. Looks like there is a small breakage in the last commit "Turn `git
> > bisect` into a full built-in":
> >
> >     $ make check-builtins
> >     ./check-builtins.sh
> >     bisect is builtin but git-bisect.sh still exists
> >     make: *** [Makefile:3561: check-builtins] Error 1
> >
> > Seeing that this is on 'next', it would be nice to see a fix in the near
> > future, certainly before we graduate this down to 'master'. Am I correct
> > in assuming that there is no reason to keep git-bisect.sh around after
> > that commit?
>
> Yeah, see:
>
>   https://lore.kernel.org/git/patch-1.1-7be23b6faa0-20221115T093130Z-avarab@gmail.com/

Ack, thanks.

Thanks, Taylor