Re: [PATCH 1/3] bisect--helper: remove unused options
- From
Jeff King <peff@peff.net>
- Date
- Nov 4, 2022, 12:53 UTC
- Message-ID
- <Y2ULXomMI7vcDuZO@coredump.intra.peff.net>
- In-Reply-To
- <489785ca45a84cffb4a2c16da15a09034829b7c6.1667561761.git.congdanhqx@gmail.com>
On Fri, Nov 04, 2022 at 06:40:10PM +0700, Đoàn Trần Công Danh wrote:
Show 12 quoted lines
> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
> index 1d2ce8a0e1..5ec2e67f59 100644
> --- a/builtin/bisect--helper.c
> +++ b/builtin/bisect--helper.c
> @@ -1283,7 +1283,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
> {
> enum {
> BISECT_RESET = 1,
> - BISECT_NEXT_CHECK,
> BISECT_TERMS,
> BISECT_START,
> BISECT_AUTOSTART,OK, makes sense. It might be nice to mention in the commit message how we got here. It looks like the callers that used this went away in d1bbbe45df (bisect--helper: reimplement `bisect_run` shell function in C, 2021-09-13) and 5e1f28d206 (bisect--helper: reimplement `bisect_visualize()` shell function in C, 2021-09-13).
Show 6 quoted lines
> @@ -1319,8 +1316,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
> N_("visualize the bisection"), BISECT_VISUALIZE),
> OPT_CMDMODE(0, "bisect-run", &cmdmode,
> N_("use <cmd>... to automatically bisect"), BISECT_RUN),
> - OPT_BOOL(0, "no-log", &nolog,
> - N_("no log for BISECT_WRITE")),Likewise digging up the history here lets us see why removing is the right thing (and the bug is not that it _should_ be used and isn't). Gábor posted a summary of the history elsewhere in the thread.
-Peff