Re: [PATCH v2 00/11] Turn git-bisect to be builtin

From: Taylor Blau <me@ttaylorr.com>
Date: Nov 15, 2022, 19:18 UTC
Message-ID: <Y3PmAP24GPAhXPOm@nand.local>
In-Reply-To: <Y27Hrkruh6++7NkO@nand.local>

On Fri, Nov 11, 2022 at 05:07:42PM -0500, Taylor Blau wrote:

Show 31 quoted lines

> On Thu, Nov 10, 2022 at 11:36:35PM +0700, Đoàn Trần Công Danh wrote:
> > This series finish the git-bisect porting from shell script into a C builtin.
> >
> > This series can't be applied cleaned on master, it needs to be applied on top
> > of the series posted at:
> > https://lore.kernel.org/git/cover.1668097286.git.congdanhqx@gmail.com/
> > AND the series rs/no-more-run-command-v, which has been integrated to next.
>
> Thanks, having both was helpful. Note that 'rs/no-more-run-command-v' was
> merged into 'master' via be4ac3b197 (Merge branch
> 'rs/no-more-run-command-v', 2022-11-08), so picking up these new patches
> only needed a merge of the other series.
>
> > Johannes Schindelin (2):
> >   bisect--helper: handle states directly
> >   Turn `git bisect` into a full built-in
> >
> > Ævar Arnfjörð Bjarmason (4):
> >   bisect tests: test for v2.30.0 "bisect run" regressions
> >   bisect: refactor bisect_run() to match CodingGuidelines
> >   bisect test: test exit codes on bad usage
> >   bisect--helper: emit usage for "git bisect"
> >
> > Đoàn Trần Công Danh (5):
> >   bisect: fix output regressions in v2.30.0
> >   bisect run: keep some of the post-v2.30.0 output
> >   bisect-run: verify_good: account for non-negative exit status
> >   bisect--helper: identify as bisect when report error
> >   bisect--helper: log: allow arbitrary number of arguments
>
> Looking good to me. Is everybody happy to start merging these two down?

Hmm. Looks like there is a small breakage in the last commit "Turn `git bisect` into a full built-in":

    $ make check-builtins
    ./check-builtins.sh
    bisect is builtin but git-bisect.sh still exists
    make: *** [Makefile:3561: check-builtins] Error 1

Seeing that this is on 'next', it would be nice to see a fix in the near future, certainly before we graduate this down to 'master'. Am I correct in assuming that there is no reason to keep git-bisect.sh around after that commit?

Thanks, Taylor