git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] maintenance --unregister: fix uninit'd data use & -Wdeclaration-after-statement

From
Taylor Blau <me@ttaylorr.com>
Date
Nov 15, 2022, 18:54 UTC
Message-ID
<Y3PgdXp30kLA15E+@nand.local>
In-Reply-To
<d66fad29eb4c80fd1e9db4cfe5077085@rjp.ie>
On Tue, Nov 15, 2022 at 06:00:45PM +0000, ronan@rjp.ie wrote:
Show 8 quoted lines
> November 15, 2022 10:35 AM, "Taylor Blau" <me@ttaylorr.com> wrote:
>
> > It was human error on my part. Please let me know if the result in
> > 'next' now is OK to you.
>
> Had a look and I'm just wondering if we're sure it's alright to clear
> the configset before using the list we found in it. Doesn't that list
> point into the configset?
It does. I should not have trusted the incoming patch so blindly. See:
    https://lore.kernel.org/git/2cbead254b77cb02d219bca8f628dc4362c045b0.1668538355.git.me@ttaylorr.com/
for a fixup on top.

Thanks, Taylor

Previous: ronan@rjp.ieNext: Taylor Blau
Message 9 of 10 in “builtin/gc.c: fix -Wdeclaration-after-statement”
  1. builtin/gc.c: fix -Wdeclaration-after-statementÆvar Arnfjörð Bjarmason, Nov 15, 2022
  2. Johannes SchindelinNov 15, 2022
  3. Johannes SchindelinNov 15, 2022
  4. Ævar Arnfjörð BjarmasonNov 15, 2022
  5. maintenance --unregister: fix uninit'd data use & -Wdeclaration-after-statementÆvar Arnfjörð Bjarmason, Nov 15, 2022
  6. ronan@rjp.ieNov 15, 2022
  7. Taylor BlauNov 15, 2022
  8. ronan@rjp.ieNov 15, 2022
  9. Taylor BlauNov 15, 2022
  10. Taylor BlauNov 15, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.