git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin/gc.c: fix -Wdeclaration-after-statement

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Nov 15, 2022, 08:04 UTC
Message-ID
<patch-1.1-54d405f15f1-20221115T080212Z-avarab@gmail.com>

In 1f80129d61b (maintenance: add option to register in a specific config, 2022-11-09) code was added which triggers a "-Wdeclaration-after-statement" warning, which is on by default with DEVELOPER=1.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---

This landed in the latest "next" push-out, causing e.g this CI failure: https://github.com/git/git/actions/runs/3467538041/jobs/5792504315

 builtin/gc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/gc.c b/builtin/gc.c
index 56b107e7f0b..22a990db0be 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -1543,6 +1543,7 @@ static int maintenance_unregister(int argc, const char **argv, const char *prefi
 	int found = 0;
 	struct string_list_item *item;
 	const struct string_list *list;
+	struct config_set cs;
 
 	argc = parse_options(argc, argv, prefix, options,
 			     builtin_maintenance_unregister_usage, 0);
@@ -1550,7 +1551,6 @@ static int maintenance_unregister(int argc, const char **argv, const char *prefi
 		usage_with_options(builtin_maintenance_unregister_usage,
 				   options);
 
-	struct config_set cs;
 	if (config_file) {
 		git_configset_init(&cs);
 		git_configset_add_file(&cs, config_file);
-- 
2.38.0.1473.g172bcc0511c
Next: Johannes Schindelin
Message 1 of 10 in “builtin/gc.c: fix -Wdeclaration-after-statement”
  1. builtin/gc.c: fix -Wdeclaration-after-statementÆvar Arnfjörð Bjarmason, Nov 15, 2022
  2. Johannes SchindelinNov 15, 2022
  3. Johannes SchindelinNov 15, 2022
  4. Ævar Arnfjörð BjarmasonNov 15, 2022
  5. maintenance --unregister: fix uninit'd data use & -Wdeclaration-after-statementÆvar Arnfjörð Bjarmason, Nov 15, 2022
  6. ronan@rjp.ieNov 15, 2022
  7. Taylor BlauNov 15, 2022
  8. ronan@rjp.ieNov 15, 2022
  9. Taylor BlauNov 15, 2022
  10. Taylor BlauNov 15, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.