From: Taylor Blau <me@ttaylorr.com>
Date: Tue, 15 Nov 2022 18:54:45 GMT
Subject: Re: [PATCH v2] maintenance --unregister: fix uninit'd data use & -Wdeclaration-after-statement
Message-ID: <Y3PgdXp30kLA15E+@nand.local>
In-Reply-To: <d66fad29eb4c80fd1e9db4cfe5077085@rjp.ie>

On Tue, Nov 15, 2022 at 06:00:45PM +0000, ronan@rjp.ie wrote:
> November 15, 2022 10:35 AM, "Taylor Blau" <me@ttaylorr.com> wrote:
>
> > It was human error on my part. Please let me know if the result in
> > 'next' now is OK to you.
>
> Had a look and I'm just wondering if we're sure it's alright to clear
> the configset before using the list we found in it. Doesn't that list
> point into the configset?

It does. I should not have trusted the incoming patch so blindly. See:

    https://lore.kernel.org/git/2cbead254b77cb02d219bca8f628dc4362c045b0.1668538355.git.me@ttaylorr.com/

for a fixup on top.

Thanks,
Taylor