Re: [PATCH v4 4/6] revision: add new parameter to exclude hidden refs
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Nov 8, 2022, 21:13 UTC
- Message-ID
- <Y2rGfjr9vPEx1JEs@nand.local>
- In-Reply-To
- <Y2pwt77e9KP5J3XD@coredump.intra.peff.net>
On Tue, Nov 08, 2022 at 10:07:35AM -0500, Jeff King wrote:
Show 10 quoted lines
> I'm sure this _could_ be made to work, but I wonder if it is worth the > trouble. If it's not going to work, though, I think we'd want to detect > the situation and complain, at least for now. And likewise the > documentation needs to make clear it only works with --all and --glob. > > Sorry to have misled in my initial suggestion to turn --visible-refs > into --exclude-hidden. However, I do still stand by that suggestion. > Even if we don't make it work with "--branches" now, the user-visible > framework is still there, so it becomes a matter of extending the > implementation later, rather than re-designing the options.
Good catch. I agree completely, so hopefully we will see something to this effect in the forthcoming v5.
I'll hold off on merging this down until we see that version.
Thanks, Taylor