Re: [PATCH v2 0/3] receive-pack: only use visible refs for connectivity check

From: Jeff King <peff@peff.net>
Date: Nov 5, 2022, 12:55 UTC
Message-ID: <Y2ZdScjauDUKOG+z@coredump.intra.peff.net>
In-Reply-To: <Y2WxAwNuKTOJEhz0@nand.local>

On Fri, Nov 04, 2022 at 08:40:35PM -0400, Taylor Blau wrote:

Show 13 quoted lines

> On Thu, Nov 03, 2022 at 03:37:25PM +0100, Patrick Steinhardt wrote:
> > Hi,
> >
> > this is the second version of my patch series that tries to improve
> > performance of the connectivity check by only considering preexisting
> > refs as uninteresting that could actually have been advertised to the
> > client.
> 
> This version was delightful to read, and I don't have any concerns with
> the approach or implementation.
> 
> I would appreciate another set of reviewer eyes on the topic, but if
> not, I am comfortable starting to merge this down as-is.

I like the overall direction, but I had some suggestions for the interface in patch 2. Hopefully Patrick agrees, and we'll see a v2.

-Peff