Re: [PATCH v3 4/6] revision: add new parameter to exclude hidden refs

From: Patrick Steinhardt <ps@pks.im>
Date: Nov 8, 2022, 08:16 UTC
Message-ID: <Y2oQb12WwEh0bpxW@ncase>
In-Reply-To: <Y2mpefFJspp4QnAz@nand.local>

On Mon, Nov 07, 2022 at 07:57:29PM -0500, Taylor Blau wrote:

Show 19 quoted lines

> On Mon, Nov 07, 2022 at 01:16:35PM +0100, Patrick Steinhardt wrote:
> > @@ -195,6 +195,13 @@ respectively, and they must begin with `refs/` when applied to `--glob`
> >  or `--all`. If a trailing '/{asterisk}' is intended, it must be given
> >  explicitly.
> >
> > +--exclude-hidden=[transfer|receive|uploadpack]::
> > +	Do not include refs that have been hidden via either one of
> > +	`transfer.hideRefs`, `receive.hideRefs` or `uploadpack.hideRefs` that
> > +	the next `--all`, `--branches`, `--tags`, `--remotes` or `--glob` would
> > +	otherwise consider.  This option is cleared when seeing one of these
> > +	pseudo-refs.
> > +
> 
> Hmm. I thought that part of the motivation behind this round was to drop
> the 'transfer' group, since it's implied by '--exclude-hidden=receive
> --exclude-hidden-uploadpack', no?
> 
> Thanks,
> Taylor

I didn't quite see the point in not providing the `transfer` group so that users can ask for only the set of refs that are hidden by both `uploadpack` and `receive`. But given that you're the second person asking for it to be dropped now and given that I don't really have a plausible usecase for this I'll drop it in the next version.

Patrick