Re: [PATCH] 0003 This patch is to allow 12 different OS's to compile and run git.

> On Fri, 6 Jun 2008, Boyd Lynn Gerber wrote:
> > On Fri, 6 Jun 2008, Junio C Hamano wrote:
> > > Boyd Lynn Gerber <gerberb@zenez.com> writes:
> > > > diff --git a/git-compat-util.h b/git-compat-util.h
> > > > index 01c4045..b3cd7b3 100644
> > > > --- a/git-compat-util.h
> > > > +++ b/git-compat-util.h
> > > > @@ -39,7 +39,12 @@
> > > >  /* Approximation of the length of the decimal representation of this type. */
> > > >  #define decimal_length(x)	((int)(sizeof(x) * 2.56 + 0.5) + 1)
> > > >  
> > > > -#if !defined(__APPLE__) && !defined(__FreeBSD__)
> > > > +/* Added for __USLC__ for any Novell devrived Compiler and Some Sys V 
> > > > +   Added _M_UNIX for any XENIX/SCO UNIX/OpenServer less than or equal
> > > > +   OpenServer 5.0.7  This is do avoided compiler hell like the other
> > > > +   OS's __APPLE__ and __FreeBSD__ */
> > > 
> > > We generally do not do changelog inside the code comment.
> > 
> > Where do you put your change log stuff, to explain why you made the 
> > change.  Maybe it is a bit left over from doing things for MySQL AB.
> 
> In the commit message. That is, if your commit message goes:
> 
>   Allow more systems to build git
> 
>   __USLC__ indicates a Novell-derived compiler or some SysV
>   __M_UNIX indicates XENIX/SCO UNIX/OpenServer before 5.0.7
>   Like Apple and BSD, both of these shouldn't have _XOPEN_SOURCE defined
> 
> then an interested user can use "git blame" on the file, and then read 
> that info in the commit message for the commit that introduced those 
> lines.
> 
> Also on the commit message: you should put the list of affected files 
> after a line with just "---", so it appears in the patch but not in the 
> commit; if we want to find out what the commit affects, we can use "git 
> log --stat" and find out for sure. The explanation of the sign-off can 
> probably go after the "---", too, although the "Signed-off-by" line should 
> be above it.