Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.

From: Jeremy Maitin-Shepard <jbms@cmu.edu>
Date: Jun 6, 2008, 19:39 UTC
Message-ID: <87bq2ez72u.fsf@jeremyms.com>
In-Reply-To: <Pine.LNX.4.64.0806061330180.18454@xenau.zenez.com>

Boyd Lynn Gerber <gerberb@zenez.com> writes:

[snip]

Show 12 quoted lines

> diff --git a/progress.c b/progress.c
> index d19f80c..11a0841 100644
> --- a/progress.c
> +++ b/progress.c
> @@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, const
> char *msg)
>  	*p_progress = NULL;
>  	if (progress->last_value != -1) {
>  		/* Force the last update */
> -		char buf[strlen(msg) + 5];
> +		/* char buf[strlen(msg) + 5]; */
> +		char *buf = malloc (strlen(msg) + 5 );

This change will result in the allocated memory being leaked, which is probably not correct. Perhaps change it to alloca instead.

-- 
Jeremy Maitin-Shepard