Re: [PATCH] 0003 This patch is to allow 12 different OS's to compile and run git.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 8, 2008, 07:45 UTC
- Message-ID
- <7vy75gl68y.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <Pine.LNX.4.64.0806072143230.18454@xenau.zenez.com>
Boyd Lynn Gerber <gerberb@zenez.com> writes:
> So I should have > ... (deleted)
More like this:
From: Boyd Lynn Gerber <gerberb@zenez.com>
Subject: [PATCH] Port to other 12 platforms
Date: Sat, 7 Jun 2008 21:46:48 -0600
To: git@vger.kernel.org
Cc: gitster@pobox.com This adds support to compile git on 12 platforms (<<whichever one you
ported including UnixWare, SCO,... are listed here.>>). __USLC__ indicates UNIX System Labs Corperation (USLC), or a
Novell-derived compiler and/or some SysV based OS's. __M_UNIX indicates
XENIX/SCO UNIX/OpenServer before 5.0.7 and prior release of and SCO OS.
Like Apple and BSD, both of these do not want _XOPEN_SOURCE defined to
allow use of <<the symbols that is hidden if you have _XOPEN_SOURCE
defined>>. Signed-off-by: Boyd Lynn Gerber <gerberb@zenez.com>
---
<< "git diff --stat -p" output for the patch here >>without removal of dynamic-sized array from progress.c, which is not really part of specific port to these 12 platforms, but is a more generic "portability fix", which might read like this:
From: Boyd Lynn Gerber <gerberb@zenez.com>
Subject: [PATCH] progress.c: avoid use of dynamic-sized array
Date: Sat, 7 Jun 2008 21:46:48 -0600
To: git@vger.kernel.org
Cc: gitster@pobox.com Dynamically sized arrays are gcc and C99 construct. It sometimes is
nice to use them but hurts portability to older compilers. This
removes the only use of the construct in stop_progress_msg(); the
function is about writing out a single line of message, and the
existing callers of this function feed messages of only bounded size
anyway, so use of dynamic array is simply overkill. Signed-off-by: Boyd Lynn Gerber <gerberb@zenez.com>
---
<< "git diff --stat -p" output for the patch here >>