git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] DWIM "git add remote ..."

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 5, 2007, 19:47 UTC
Message-ID
<Pine.LNX.4.64.0712051946350.27959@racer.site>
In-Reply-To
<alpine.LFD.0.9999.0712051129280.13796@woody.linux-foundation.org>
Hi,
On Wed, 5 Dec 2007, Linus Torvalds wrote:
Show 18 quoted lines
> On Wed, 5 Dec 2007, Johannes Schindelin wrote:
> > 
> > It is wrong to divert to "git remote add" when you typed the (more 
> > English) "git add remote".  But is it also pretty convenient.
> 
> Please don't do cute things like this. Suddenly "git add remote" has two 
> different meanings depending on whether you have a file called "remote" 
> or not. That is *not* ok.
> 
> Not to mention the fact that your patch is also a horrible piece of 
> bug-infested shit, to put it less-than-politely. Namely, you now broke 
> "git add remote" when "remote" is a symbolic link pointing to 
> hyperspace.
> 
> But even if you fix that bug, it only goes to show just how misguided 
> things like these are. It's a *lot* more important to make sense and not 
> have surprising special cases, than to try to make git command lines act 
> as if they were free-form English.

Hehe. You're right, of course. But I could not resist showing off that patch which I wrote after I mixed up the command line of "remote add" for the 926th time.

Ciao, Dscho

Previous: Linus Torvalds
Message 14 of 14 in “builtin-remote”
  1. 0/6 builtin-remoteJohannes Schindelin, Dec 5, 2007
  2. (unknown)Johannes Schindelin, Dec 5, 2007
  3. Johannes SchindelinDec 5, 2007
  4. 1/6 path-list: add functions to work with unsorted listsJohannes Schindelin, Dec 5, 2007
  5. 2/6 parseopt: add flag to stop on first non optionJohannes Schindelin, Dec 5, 2007
  6. 3/6 Test "git remote show" and "git remote prune"Johannes Schindelin, Dec 5, 2007
  7. René ScharfeDec 5, 2007
  8. Johannes SchindelinDec 5, 2007
  9. 4/6 Make git-remote a builtinJohannes Schindelin, Dec 5, 2007
  10. 7/6 builtin-remote: guard remote->url accesses by remote->url_nr checkJohannes Schindelin, Dec 5, 2007
  11. 5/6 builtin-remote: prune remotes correctly that were added with --mirrorJohannes Schindelin, Dec 5, 2007
  12. 6/6 DWIM "git add remote ..."Johannes Schindelin, Dec 5, 2007
  13. Linus TorvaldsDec 5, 2007
  14. Johannes SchindelinDec 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.