Re: [PATCH 6/6] DWIM "git add remote ..."
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 5, 2007, 19:47 UTC
- Message-ID
- <Pine.LNX.4.64.0712051946350.27959@racer.site>
- In-Reply-To
- <alpine.LFD.0.9999.0712051129280.13796@woody.linux-foundation.org>
Hi,
On Wed, 5 Dec 2007, Linus Torvalds wrote:
Show 18 quoted lines
> On Wed, 5 Dec 2007, Johannes Schindelin wrote: > > > > It is wrong to divert to "git remote add" when you typed the (more > > English) "git add remote". But is it also pretty convenient. > > Please don't do cute things like this. Suddenly "git add remote" has two > different meanings depending on whether you have a file called "remote" > or not. That is *not* ok. > > Not to mention the fact that your patch is also a horrible piece of > bug-infested shit, to put it less-than-politely. Namely, you now broke > "git add remote" when "remote" is a symbolic link pointing to > hyperspace. > > But even if you fix that bug, it only goes to show just how misguided > things like these are. It's a *lot* more important to make sense and not > have surprising special cases, than to try to make git command lines act > as if they were free-form English.
Hehe. You're right, of course. But I could not resist showing off that patch which I wrote after I mixed up the command line of "remote add" for the 926th time.
Ciao, Dscho