git/list[1] front-page[2] threads[3] people[4] search[5] about
 

(unknown)

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 5, 2007, 19:00 UTC
Message-ID
<Pine.LNX.4.64.0712051900370.27959@racer.site>
In-Reply-To
<Pine.LNX.4.64.0712051858270.27959@racer.site>
[PATCH 1/6] path-list: add functions to work with unsorted lists

Up to now, path-lists were sorted at all times. But sometimes it is much more convenient to build the list and sort it at the end, or sort it not at all.

Add path_list_append() and sort_path_list() to allow that.

Also, add the unsorted_path_list_has_path() function, to do a linear search.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	I should have done this much earlier...
 path-list.c |   30 ++++++++++++++++++++++++++++++
 path-list.h |    8 +++++++-
 2 files changed, 37 insertions(+), 1 deletions(-)
diff --git a/path-list.c b/path-list.c
index 3d83b7b..92e5cf2 100644
--- a/path-list.c
+++ b/path-list.c
@@ -102,3 +102,33 @@ void print_path_list(const char *text, const struct path_list *p)
 	for (i = 0; i < p->nr; i++)
 		printf("%s:%p\n", p->items[i].path, p->items[i].util);
 }
+
+struct path_list_item *path_list_append(const char *path, struct path_list *list)
+{
+	ALLOC_GROW(list->items, list->nr + 1, list->alloc);
+	list->items[list->nr].path =
+		list->strdup_paths ? xstrdup(path) : (char *)path;
+	return list->items + list->nr++;
+}
+
+static int cmp_items(const void *a, const void *b)
+{
+	const struct path_list_item *one = a;
+	const struct path_list_item *two = b;
+	return strcmp(one->path, two->path);
+}
+
+void sort_path_list(struct path_list *list)
+{
+	qsort(list->items, list->nr, sizeof(*list->items), cmp_items);
+}
+
+int unsorted_path_list_has_path(struct path_list *list, const char *path)
+{
+	int i;
+	for (i = 0; i < list->nr; i++)
+		if (!strcmp(path, list->items[i].path))
+			return 1;
+	return 0;
+}
+
diff --git a/path-list.h b/path-list.h
index 5931e2c..ca2cbba 100644
--- a/path-list.h
+++ b/path-list.h
@@ -13,10 +13,16 @@ struct path_list
 };
 
 void print_path_list(const char *text, const struct path_list *p);
+void path_list_clear(struct path_list *list, int free_util);
 
+/* Use these functions only on sorted lists: */
 int path_list_has_path(const struct path_list *list, const char *path);
-void path_list_clear(struct path_list *list, int free_util);
 struct path_list_item *path_list_insert(const char *path, struct path_list *list);
 struct path_list_item *path_list_lookup(const char *path, struct path_list *list);
 
+/* Use these functions only on unsorted lists: */
+struct path_list_item *path_list_append(const char *path, struct path_list *list);
+void sort_path_list(struct path_list *list);
+int unsorted_path_list_has_path(struct path_list *list, const char *path);
+
 #endif /* PATH_LIST_H */
-- 
1.5.3.7.2157.g9598e
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 2 of 14 in “builtin-remote”
  1. 0/6 builtin-remoteJohannes Schindelin, Dec 5, 2007
  2. (unknown)Johannes Schindelin, Dec 5, 2007
  3. Johannes SchindelinDec 5, 2007
  4. 1/6 path-list: add functions to work with unsorted listsJohannes Schindelin, Dec 5, 2007
  5. 2/6 parseopt: add flag to stop on first non optionJohannes Schindelin, Dec 5, 2007
  6. 3/6 Test "git remote show" and "git remote prune"Johannes Schindelin, Dec 5, 2007
  7. René ScharfeDec 5, 2007
  8. Johannes SchindelinDec 5, 2007
  9. 4/6 Make git-remote a builtinJohannes Schindelin, Dec 5, 2007
  10. 7/6 builtin-remote: guard remote->url accesses by remote->url_nr checkJohannes Schindelin, Dec 5, 2007
  11. 5/6 builtin-remote: prune remotes correctly that were added with --mirrorJohannes Schindelin, Dec 5, 2007
  12. 6/6 DWIM "git add remote ..."Johannes Schindelin, Dec 5, 2007
  13. Linus TorvaldsDec 5, 2007
  14. Johannes SchindelinDec 5, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.