git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Newbie: report of first experience with git-rebase.

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Oct 31, 2007, 22:35 UTC
Message-ID
<Pine.LNX.4.64.0710311823070.7357@iabervon.org>
In-Reply-To
<4728FC5C.30709@midwinter.com>
On Wed, 31 Oct 2007, Steven Grimm wrote:
Show 22 quoted lines
> J. Bruce Fields wrote:
> > I ran into the same confusion as the original poster when starting to
> > use rebase, so I suspect it's common.
> >   
> 
> I've been using rebase just about every day for close to a year and it *still*
> annoys me when it happens. Especially the "Did you forget to git add?" part of
> the message. The thought that always goes through my head is, "No, Mr. Rebase,
> I did NOT forget to git add. I remembered to git add, then you were too stupid
> to do the right thing after that."
> 
> Just happened to me this morning, in fact: I had a quick hack in place to work
> around a bug, the bug got fixed for real, and I rebased. In the process of
> conflict resolution I saw that my workaround wasn't needed any more and
> accepted the upstream version of that particular part of the file. Ran git-add
> on it, then rebase --continue, and boom, was accused of forgetting to run
> git-add.
> 
> It is a minor annoyance and nowadays I just sigh a bit and run --skip instead,
> but it'd be nice if it didn't happen. I don't like having to care whether or
> not I happened to change other files in a particular commit after I resolve
> conflicts in one file in favor of the upstream version.

I think it's worth requiring you to say --skip in order to acknowledge that you won't have as many commits and you'll lose the commit message. On the other hand, the message should probably suggest that you might want to skip this commit instead of suggesting that you come up with some other change to include in it.

Certainly, if "git diff" returns no changes, "git add" is a bad suggestion, and it would be nicer to suggest something possibly correct.

	-Daniel
*This .sig left intentionally blank*
Previous: Steven GrimmNext: J. Bruce Fields
Message 7 of 20 in “Newbie: report of first experience with git-rebase.”
  1. Sergei OrganovOct 31, 2007
  2. Björn SteinbrinkOct 31, 2007
  3. Sergei OrganovOct 31, 2007
  4. Johannes SchindelinOct 31, 2007
  5. J. Bruce FieldsOct 31, 2007
  6. Steven GrimmOct 31, 2007
  7. Daniel BarkalowOct 31, 2007
  8. J. Bruce FieldsOct 31, 2007
  9. Junio C HamanoOct 31, 2007
  10. David KastrupOct 31, 2007
  11. Nicolas PitreNov 1, 2007
  12. Sergei OrganovNov 1, 2007
  13. Johannes SchindelinNov 1, 2007
  14. J. Bruce FieldsNov 1, 2007
  15. Junio C HamanoNov 1, 2007
  16. Andreas EricssonNov 2, 2007
  17. Junio C HamanoNov 2, 2007
  18. David KastrupOct 31, 2007
  19. Alex RiesenOct 31, 2007
  20. Andreas EricssonNov 2, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.