Re: [GIT-GUI PATCH 2/3] po2msg: ignore untranslated messages

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 31, 2007, 02:23 UTC
Message-ID: <Pine.LNX.4.64.0710310222110.4362@racer.site>
In-Reply-To: <7vabq0l7wn.fsf@gitster.siamese.dyndns.org>

Hi,

On Tue, 30 Oct 2007, Junio C Hamano wrote:

Show 24 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Do not generate translations when the translated message is empty.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >  po/po2msg.sh |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/po/po2msg.sh b/po/po2msg.sh
> > index 48a2669..91d420b 100644
> > --- a/po/po2msg.sh
> > +++ b/po/po2msg.sh
> > @@ -62,6 +62,9 @@ proc flush_msg {} {
> >  	if {$msgid == ""} {
> >  		set prefix "set ::msgcat::header"
> >  	} else {
> > +		if {$msgstr == ""} {
> > +			return
> > +		}
> >  		set prefix "::msgcat::mcset $lang \"[u2a $msgid]\""
> >  	}
> 
> Is this change to fix some real issues?

Yes. I compared the output of po2msg.sh with that of msgfmt, and only with this change (and 1/3) they came up identical.

Ciao, Dscho