Re: [GIT-GUI PATCH 2/3] po2msg: ignore untranslated messages

From: Christian Stimming <stimming@tuhh.de>
Date: Oct 30, 2007, 20:44 UTC
Message-ID: <200710302144.39149.stimming@tuhh.de>
In-Reply-To: <7vabq0l7wn.fsf@gitster.siamese.dyndns.org>

Am Dienstag, 30. Oktober 2007 20:27 schrieb Junio C Hamano:

Show 22 quoted lines

> > Do not generate translations when the translated message is empty.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> >  po/po2msg.sh |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/po/po2msg.sh b/po/po2msg.sh
> > index 48a2669..91d420b 100644
> > --- a/po/po2msg.sh
> > +++ b/po/po2msg.sh
> > @@ -62,6 +62,9 @@ proc flush_msg {} {
> >  	if {$msgid == ""} {
> >  		set prefix "set ::msgcat::header"
> >  	} else {
> > +		if {$msgstr == ""} {
> > +			return
> > +		}
> >  		set prefix "::msgcat::mcset $lang \"[u2a $msgid]\""
> >  	}
>
> Is this change to fix some real issues?

I don't think to - it just makes the resulting foo.msg file smaller.

> Sometimes it is handy to be able to translate a non-empty string
> into an empty one in one target language.

Err... no, this is not the case. The semantics of an msgstr == "" is identical to saying "No translation exists to this source string". Nothing more, nothing less. You can't specify a translation that should map a given string to an empty string. (If you make up a case when that would make some sense, usually the source string is rather weirdly chosen and should be reworded.)

Christian