git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/9] Introduce entry point for launching add--interactive.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Sep 17, 2007, 23:27 UTC
Message-ID
<Pine.LNX.4.64.0709180027100.28586@racer.site>
In-Reply-To
<1190070792.10112.15.camel@hinata.boston.redhat.com>
Hi,
On Mon, 17 Sep 2007, Kristian H?gsberg wrote:
Show 26 quoted lines
> On Thu, 2007-09-06 at 17:31 +0100, Johannes Schindelin wrote:
> > 
> > On Wed, 5 Sep 2007, Kristian Høgsberg wrote:
> > 
> > > diff --git a/builtin-add.c b/builtin-add.c
> > > index 3dd4ded..e79e8f7 100644
> > > --- a/builtin-add.c
> > > +++ b/builtin-add.c
> > > @@ -153,6 +154,13 @@ static int git_add_config(const char *var, const char *value)
> > >  	return git_default_config(var, value);
> > >  }
> > >  
> > > +int interactive_add(void)
> > > +{
> > > +	const char *argv[2] = { "add--interactive", NULL };
> > > +
> > > +	return run_command_v_opt(argv, RUN_GIT_CMD);
> > > +}
> > 
> > I'd rather have this in builtin-commit.c, since it is quite funny if 
> > builtin-add.c has code to fork() and exec() itself (eventually, that 
> > is) ;-)
> 
> Huh... it ends up in the same binary, and interactive_add() sounds like 
> it should live in builtin-add.c rather than builtin-commit.c.  Either 
> way, I don't care too much, but can we fix it up later?

Well, you are probably right on the former, and therefore we do not have to do the latter.

Thanks, Dscho

Previous: Kristian HøgsbergNext: Junio C Hamano
Message 20 of 25 in “Enable wt-status output to a given FILE pointer.”
  1. 1/9 Enable wt-status output to a given FILE pointer.Kristian Høgsberg, Sep 6, 2007
  2. 2/9 Enable wt-status to run against non-standard index file.Kristian Høgsberg, Sep 6, 2007
  3. 3/9 Add strbuf_printf() to do formatted printing to a strbuf.Kristian Høgsberg, Sep 6, 2007
  4. 4/9 Introduce entry point for launching add--interactive.Kristian Høgsberg, Sep 6, 2007
  5. 5/9 Introduce strbuf_read_fd().Kristian Høgsberg, Sep 6, 2007
  6. 6/9 Rewrite launch_editor, create_tag and stripspace to use strbufs.Kristian Høgsberg, Sep 6, 2007
  7. 7/9 Add strbuf_read_path().Kristian Høgsberg, Sep 6, 2007
  8. 8/9 Export rerere() and launch_editor().Kristian Høgsberg, Sep 6, 2007
  9. 9/9 Implement git commit as a builtin command.Kristian Høgsberg, Sep 6, 2007
  10. Johannes SchindelinSep 6, 2007
  11. Kristian HøgsbergSep 17, 2007
  12. Johannes SchindelinSep 17, 2007
  13. Jeff KingSep 17, 2007
  14. Kristian HøgsbergSep 18, 2007
  15. Johannes SchindelinSep 6, 2007
  16. Johannes SchindelinSep 6, 2007
  17. Kristian HøgsbergSep 17, 2007
  18. Johannes SchindelinSep 6, 2007
  19. Kristian HøgsbergSep 17, 2007
  20. Johannes SchindelinSep 17, 2007
  21. Junio C HamanoSep 6, 2007
  22. Pierre HabouzitSep 6, 2007
  23. Pierre HabouzitSep 6, 2007
  24. Johannes SchindelinSep 6, 2007
  25. Kristian HøgsbergSep 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.