Re: [PATCH 4/9] Introduce entry point for launching add--interactive.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 6, 2007, 16:31 UTC
Message-ID: <Pine.LNX.4.64.0709061729270.28586@racer.site>
In-Reply-To: <11890382253220-git-send-email-krh@redhat.com>

Hi,

On Wed, 5 Sep 2007, Kristian Høgsberg wrote:

Show 14 quoted lines

> diff --git a/builtin-add.c b/builtin-add.c
> index 3dd4ded..e79e8f7 100644
> --- a/builtin-add.c
> +++ b/builtin-add.c
> @@ -153,6 +154,13 @@ static int git_add_config(const char *var, const char *value)
>  	return git_default_config(var, value);
>  }
>  
> +int interactive_add(void)
> +{
> +	const char *argv[2] = { "add--interactive", NULL };
> +
> +	return run_command_v_opt(argv, RUN_GIT_CMD);
> +}

I'd rather have this in builtin-commit.c, since it is quite funny if builtin-add.c has code to fork() and exec() itself (eventually, that is) ;-)

Show 17 quoted lines

> diff --git a/commit.h b/commit.h
> index 467872e..64e1d4b 100644
> --- a/commit.h
> +++ b/commit.h
> @@ -122,4 +122,13 @@ extern struct commit_list *get_shallow_commits(struct object_array *heads,
>  		int depth, int shallow_flag, int not_shallow_flag);
>  
>  int in_merge_bases(struct commit *, struct commit **, int);
> +
> +extern const unsigned char *
> +create_commit(const unsigned char *tree_sha1,
> +	      unsigned char parent_sha1[][20], int parents,
> +	      const char *author_info, const char *committer_info,
> +	      const char *message, int length);
> +
> +extern int interactive_add(void);
> +

Just a guess: you did not want create_commit() to creep in here, right?

Ciao, Dscho