Re: [PATCH 9/9] Implement git commit as a builtin command.

From: Kristian Høgsberg <krh@redhat.com>
Date: Sep 18, 2007, 00:11 UTC
Message-ID: <1190074285.10112.25.camel@hinata.boston.redhat.com>
In-Reply-To: <20070917235645.GG24342@sigill.intra.peff.net>

On Mon, 2007-09-17 at 19:56 -0400, Jeff King wrote:

Show 15 quoted lines

> On Mon, Sep 17, 2007 at 06:58:01PM -0400, Kristian Høgsberg wrote:
> 
> > > > -	builtin-runstatus.o \
> > > 
> > > Better keep it; some people's scripts could depend on it.
> > 
> > Seriously?  Why don't we remove it and see if somebody yells?  It's more
> > of an implementation detail than most other git commands; if you need
> > status output in your script why wouldn't you just run git status?
> 
> As the author of builtin-runstatus, I had always intended that it was a
> temporary part of the transition to a C git-commit, and would go away
> then. But I see in the interim somebody documented it.  It should
> perhaps have been called git-status--helper, and the documentation
> should have read "DO NOT USE THIS."

That's what I suspected, thanks for clearing that up. It definitely feels more like a step towards a built-in commit than a useful command on it's own. It plugs right into this work, so as such, it's been a success.

Kristian