git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add read_cache to builtin-check-attr

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 14, 2007, 14:08 UTC
Message-ID
<Pine.LNX.4.64.0708141506260.25989@racer.site>
In-Reply-To
<20070814132209.GJ21692@lavos.net>
Hi,
On Tue, 14 Aug 2007, Brian Downing wrote:
Show 6 quoted lines
> On Tue, Aug 14, 2007 at 08:18:38AM -0500, Brian Downing wrote:
> > We can now read .gitattributes files out of the index, but the index
> > must be loaded for this to work.
> 
> This was supposed to be In-Reply-To Junio's patch, "attr.c: read
> .gitattributes from index as well."  It's not much use without it.
Shouldn't read_cache() be _only_ called if
- it has not been read yet, and
- .gitattributes was not found in the work tree?
IOW check-attr is the wrong place for your patch IMHO.

Ciao, Dscho

Previous: Brian DowningNext: Brian Downing
Message 3 of 8 in “Add read_cache to builtin-check-attr”
  1. Add read_cache to builtin-check-attrBrian Downing, Aug 14, 2007
  2. Brian DowningAug 14, 2007
  3. Johannes SchindelinAug 14, 2007
  4. Brian DowningAug 14, 2007
  5. Johannes SchindelinAug 14, 2007
  6. Junio C HamanoAug 14, 2007
  7. Brian DowningAug 14, 2007
  8. Junio C HamanoAug 15, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.