Re: [PATCH] Add read_cache to builtin-check-attr
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 14, 2007, 18:38 UTC
- Message-ID
- <7vhcn2c673.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <11870975181798-git-send-email-bdowning@lavos.net>
Brian Downing <bdowning@lavos.net> writes:
> We can now read .gitattributes files out of the index, but the index > must be loaded for this to work.
That interface is at too low a level, I am afraid. Many commands do want to control when they read the index and it affects the result, especially when the work tree traversal implemented in dir.c is involved.
I am not rejecting/objecting, but just raising concerns. I do not have time to review this today, but just wanted to see if you fully assessed the implications (and if so that would save work on my end).