From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 14 Aug 2007 14:08:52 GMT
Subject: Re: [PATCH] Add read_cache to builtin-check-attr
Message-ID: <Pine.LNX.4.64.0708141506260.25989@racer.site>
In-Reply-To: <20070814132209.GJ21692@lavos.net>

Hi,

On Tue, 14 Aug 2007, Brian Downing wrote:

> On Tue, Aug 14, 2007 at 08:18:38AM -0500, Brian Downing wrote:
> > We can now read .gitattributes files out of the index, but the index
> > must be loaded for this to work.
> 
> This was supposed to be In-Reply-To Junio's patch, "attr.c: read
> .gitattributes from index as well."  It's not much use without it.

Shouldn't read_cache() be _only_ called if

- it has not been read yet, and
- .gitattributes was not found in the work tree?

IOW check-attr is the wrong place for your patch IMHO.

Ciao,
Dscho