Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch]

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Jul 18, 2007, 03:23 UTC
Message-ID: <Pine.LNX.4.64.0707172302560.14596@iabervon.org>
In-Reply-To: <Pine.LNX.4.64.0707172216420.14596@iabervon.org>

On Tue, 17 Jul 2007, Daniel Barkalow wrote:

Show 14 quoted lines

> On Tue, 17 Jul 2007, Johannes Schindelin wrote:
> 
> > The transport specific stuff was moved into libgit.a, and the
> > bundle specific stuff will not be left behind.
> > 
> > This is a big code move, with one exception: the function
> > unbundle() no longer outputs the list of refs.  You have to call
> > list_bundle_refs() yourself for that.
> 
> You should use -C on this sort of thing, so that the interesting aspects 
> of the patch are easier to see. (It actually comes out longer in this 
> case, but it's far easier to tell that the code in the new file is the 
> same as the old code.) Can you tell I've been rearranging a lot of code 
> lately and trying to make the patches not look really scary?

Actually, I ended up touching this up a tiny bit, too: I ordered the functions in bundle.c the way they were in builtin-bundle.c (so that the patch is more trivial) and removed the blank lines at the end of the file. This makes the "git diff -C" output really obvious.

(Someday, I'd like to have a diff that can show that a substantial block of '+' lines matches a block of lines from somewhere in the "before" content, so reviewers can verify that the patch reorders code but doesn't change it, or changes it in certain ways. But, of course, that's both hard to generate and hard to display usefully.)

	-Daniel
*This .sig left intentionally blank*