Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch]

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jul 18, 2007, 06:19 UTC
Message-ID: <20070718061931.GZ32566@spearce.org>
In-Reply-To: <7vy7he8cjl.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> It might not be actually so bad.  But I wonder if it would be
> more obvious if you do not show the whole "a-" lines but leave
> just a marker there.  That is (ugliness of "a@@" and "a-" that
> made me wash my eyes needs to be fixed, though -- but that is
> only the syntax):
> 
> a@@ -1598,43 +1635,6 a@@ apply_config
>   
>   ######################################################################
>   ##
> a-<<< Block a was originally here >>>
>   ## ui construction
>   
>   set ui_comm {}
> 
> You are coming up with a new output format that is only used
> when it is a straight move and nothing else, so by definition
> there is really no need to show both removal and addition.

Yea, this I like even better than what I posted. Now we just need a suck^H^H^H^Hprogrammer to implement a working prototype and see how folks like more realistic diffs generated with it. ;-)

-- 
Shawn.