Re: [PATCH 1/3] Move bundle specific stuff into bundle.[ch]

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Jul 18, 2007, 02:48 UTC
Message-ID: <Pine.LNX.4.64.0707172216420.14596@iabervon.org>
In-Reply-To: <Pine.LNX.4.64.0707172346450.14781@racer.site>

On Tue, 17 Jul 2007, Johannes Schindelin wrote:

Show 6 quoted lines

> The transport specific stuff was moved into libgit.a, and the
> bundle specific stuff will not be left behind.
> 
> This is a big code move, with one exception: the function
> unbundle() no longer outputs the list of refs.  You have to call
> list_bundle_refs() yourself for that.

You should use -C on this sort of thing, so that the interesting aspects of the patch are easier to see. (It actually comes out longer in this case, but it's far easier to tell that the code in the new file is the same as the old code.) Can you tell I've been rearranging a lot of code lately and trying to make the patches not look really scary?

Aside from presentation, it looks good to me. Shall I stick the bundle changes into my series? I'd like to have them come before the patch to switch to builtin-fetch, so that there aren't any revisions where "git fetch" doesn't have bundle support.

And I think it would be best to take part 3 as a review fix to my final patch.

	-Daniel
*This .sig left intentionally blank*