From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 07 Jul 2007 18:52:35 GMT
Subject: Re: [PATCH] diff-lib.c: don't strdup twice
Message-ID: <Pine.LNX.4.64.0707071951340.4093@racer.site>
In-Reply-To: <468FD91C.7040506@lsrfire.ath.cx>

Hi,

On Sat, 7 Jul 2007, Ren? Scharfe wrote:

> The static function read_directory in diff-lib.c is only ever called 
> with struct path_list lists with .strdup_paths turned on, i.e. 
> path_list_insert will strdup the paths for us (again).  Let's take 
> advantage of that and stop doing it twice.

Indeed.

Acked-by: Johannes E. Schindelin <johannes.schindelin@gmx.de>

Thanks,
Dscho