Re: [PATCH] revision: allow selection of commits that do not match a pattern

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 7, 2007, 17:33 UTC
Message-ID: <Pine.LNX.4.64.0707071831300.4093@racer.site>
In-Reply-To: <20070707165208.GC1528MdfPADPa@greensroom.kotnet.org>

Hi,

On Sat, 7 Jul 2007, Sven Verdoolaege wrote:

Show 8 quoted lines

> On Sat, Jul 07, 2007 at 05:27:23PM +0100, Johannes Schindelin wrote:
> > I suspect that with this patch,
> > 
> > 	git rev-list --not --grep bugfix HEAD
> > 
> > does not work as expected. Why?
> 
> Well... I guess that depends on what you expect...

Well, at least you hopefully that it is confusing. To use --not for grep patterns _as well_ as for revision arguments.

Show 8 quoted lines

> > Why not make "git rev-list --grep '!bugfix' HEAD" work?
> > 
> > Yes, you would have to have a special exception that the prefix "!!" 
> > actually matches an exclamation mark, but I'd be willing to live with 
> > that.
> 
> Hmm... what if you want to (not) match anything starting with
> one or more '!' ?

Yeah, that would not work.

> How about I add a '--invert-match' option that would
> apply to all following match options?
> Or we could escape the '!' with backslash.

If we want to match it at the beginning. Yes, that sounds more reasonable to me.

Ciao, Dscho