Re: [PATCH] revision: allow selection of commits that do not match a pattern

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 7, 2007, 16:27 UTC
Message-ID: <Pine.LNX.4.64.0707071724410.4093@racer.site>
In-Reply-To: <20070707153001.GA10408MdfPADPa@greensroom.kotnet.org>

Hi,

On Sat, 7 Jul 2007, Sven Verdoolaege wrote:

> We do this by maintaining two lists of patterns, one for
> those that should match and one for those that should not match.

I suspect that with this patch,

	git rev-list --not --grep bugfix HEAD

does not work as expected. Why? Because the --not is heeded when interpreting "HEAD". And that is confusing, because you use --not for two completely unrelated things.

Why not make "git rev-list --grep '!bugfix' HEAD" work?

Yes, you would have to have a special exception that the prefix "!!" actually matches an exclamation mark, but I'd be willing to live with that.

Ciao, Dscho