Re: [PATCH] revision: allow selection of commits that do not match a pattern

From: Sven Verdoolaege <skimo@kotnet.org>
Date: Jul 7, 2007, 16:52 UTC
Message-ID: <20070707165208.GC1528MdfPADPa@greensroom.kotnet.org>
In-Reply-To: <Pine.LNX.4.64.0707071724410.4093@racer.site>

On Sat, Jul 07, 2007 at 05:27:23PM +0100, Johannes Schindelin wrote:

Show 5 quoted lines

> I suspect that with this patch,
> 
> 	git rev-list --not --grep bugfix HEAD
> 
> does not work as expected. Why?

Well... I guess that depends on what you expect...

Show 5 quoted lines

> Why not make "git rev-list --grep '!bugfix' HEAD" work?
> 
> Yes, you would have to have a special exception that the prefix "!!" 
> actually matches an exclamation mark, but I'd be willing to live with 
> that.

Hmm... what if you want to (not) match anything starting with one or more '!' ? How about I add a '--invert-match' option that would apply to all following match options? Or we could escape the '!' with backslash.

skimo