Re: [PATCH 1/2] Move the pick_author code to git-sh-setup

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 24, 2007, 10:22 UTC
Message-ID: <Pine.LNX.4.64.0706241118250.4059@racer.site>
In-Reply-To: <7v7ipt3lh6.fsf@assigned-by-dhcp.cox.net>

Hi,

On Sat, 23 Jun 2007, Junio C Hamano wrote:

Show 9 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > -	set_author_env=`git show -s --pretty=raw --encoding="$encoding" "$use_commit" |
> > -	LANG=C LC_ALL=C sed -ne "$pick_author_script"`
> > -	eval "$set_author_env"
> > ...
> > +	eval $(get_author_ident_from_commit "$use_commit")
> 
> Are you sure about this part of the change?

No, I am not.

> I suspect that you are losing IFS by not dq'ing the argument you give to 
> the eval.

That is well possible. Quoting in shell is such a hassle, and I never seem to get it right.

Therefore I did a minimal test, namely committing with another GIT_AUTHOR_NAME (which has spaces in it), and then commiting again, with "-c HEAD". Which did what I expected: the second commit had the same author name as the first one.

So I thought that it was okay.

Ciao, Dscho